plugins/getstream/vision_agents/plugins/getstream/_track_resolver.py (4)

34-47: 💤 Low value

Collapse redundant elif/else.

Both elif and else return "video", so the explicit branch is dead.

Refactor

 def _get_webrtc_kind(stream_track_type: StreamTrackType.ValueType) -> str:
     """Get the expected WebRTC kind (audio/video) for an SFU track type."""
     if stream_track_type in (
         StreamTrackType.TRACK_TYPE_AUDIO,
         StreamTrackType.TRACK_TYPE_SCREEN_SHARE_AUDIO,
     ):
         return "audio"
-    elif stream_track_type in (
-        StreamTrackType.TRACK_TYPE_VIDEO,
-        StreamTrackType.TRACK_TYPE_SCREEN_SHARE,
-    ):
-        return "video"
-    else:
-        return "video"
+    return "video"

---

97-106: 💤 Low value

Reuse path rewrites the map entry unnecessarily.

_reuse_known already flips entry.published = True on the existing object, then resolve() constructs a fresh _TrackEntry and reassigns self._track_map[track_key]. Functionally identical, but the double-write is a minor smell. Either drop the mutation in _reuse_known (let line 105 own it) or skip the rewrite when reused.

---

148-163: 💤 Low value

Single-shot migration leaves additional stale sessions in the map.

The loop returns on the first match. If a user has accumulated multiple stale _TrackKeys for the same stream_track_type (rapid reconnects), only one is migrated/deleted; the rest linger until process exit. Probably benign, but consider deleting all matches and returning the most recent.

---

234-247: 💤 Low value

TTL eviction logged at warning — possibly noisy on participant churn.

Stale pending eviction is the expected outcome when a participant leaves before SFU confirms a track that was registered but cancel() didn't cover (e.g., race between track_added and departure). Per the PR description ("Change logging for unresolved-track removal from warning to debug"), consider logger.debug here unless eviction genuinely indicates a bug.

plugins/getstream/tests/test_track_resolver.py (1)

7-7: ⚡ Quick win

Import TrackResolver via the public package API, not _track_resolver.

Line 7 imports from a private module path, which couples tests to internal module structure. Re-export TrackResolver from the package and import from that public path.

Proposed change

-from vision_agents.plugins.getstream._track_resolver import TrackResolver
+from vision_agents.plugins.getstream import TrackResolver

# vision_agents/plugins/getstream/__init__.py
from ._track_resolver import TrackResolver

As per coding guidelines: "Never import from private modules (_foo) outside of the package's own __init__.py. Use the public re-export instead."